Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor change, increase adam-cli usage width to 150 characters #91

Merged
merged 1 commit into from
Feb 10, 2014
Merged

Minor change, increase adam-cli usage width to 150 characters #91

merged 1 commit into from
Feb 10, 2014

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Feb 10, 2014

Most of my terminal windows are set wider than 60 characters, merge or close without as you wish.

@tdanford
Copy link
Contributor

The Args4J documentation isn't great (http://args4j.kohsuke.org/args4j/apidocs/org/kohsuke/args4j/CmdLineParser.html#setUsageWidth(int)) -- does this only affect the usage of the output for errors, or is it changing anything about the input at all?

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/100/

@heuermh
Copy link
Member Author

heuermh commented Feb 10, 2014

Thanks for the quick feedback. For all I know it just helps with line wrapping when generating --help option documentation, e.g. this lovely one from README.md

 -spark_master VAL                      : Spark Master (default = "local[#cores]
                                          ")

@tdanford
Copy link
Contributor

Eeesh. That is ugly. More searching on teh web seems to confirm my suspicions about it being for line wrapping in error/info reporting? So I'll let it sit for a few minutes, and then merge if there are no objections.

tdanford added a commit that referenced this pull request Feb 10, 2014
@tdanford
Merge pull request #91 from heuermh/usage-width
b8dd42a 
Minor change, increase adam-cli usage width to 150 characters
@tdanford tdanford merged commit b8dd42a into bigdatagenomics:master Feb 10, 2014
@tdanford
Copy link
Contributor

Thanks Michael!

@heuermh heuermh deleted the usage-width branch February 10, 2014 22:05
@heuermh
Copy link
Member Author

heuermh commented Feb 10, 2014

Thank you, Tim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heuermh @tdanford @AmplabJenkins